Compat with servers containing packages with user no channel #13590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Apr 1, 2023
SSE4
reviewed
Apr 3, 2023
| for reference in response: | ||
| name, version, user, channel, revision = get_reference_fields(reference) | ||
| # In Conan 2.0 it is possible to have user and not channel, skip it | ||
| if user and not channel: |
There was a problem hiding this comment.
is it possible to have channel and not user?
1 task
czoido
approved these changes
Apr 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Provide compatibility with servers containing Conan 2.0 packages with user and no channel.
Docs: Omit
Doesn't provide tests because it is very difficult, because the limitations are also hardcoded in the server used for testing. I have tested it manually against my server.
Close #13588